Fix compatibility with Hummingbird theme #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosomb
approved these changes
Feb 1, 2024
florine2623
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Hello @SharakPL ,
I tested this PR with PrestaShop/hummingbird#584 together.
With classic theme LGTM.
But with hummingbird, the rating from productcomments is missing :
Screen.Recording.2024-02-02.at.10.13.10.mov
Am I missing something ? :)
|
@florine2623 please check if your product with rating has a layout with classes like this:
|
florine2623
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Hello @SharakPL ,
I tested with PrestaShop/hummingbird#600
(That PR includes PrestaShop/hummingbird#584)
I have the following :
It is missing has-reviews and reviews-loaded.
Here's my product :
Screen.Recording.2024-03-06.at.10.01.04.mov
Thanks!
|
@PrestaShop/qa-functional , I need your help on that, I can't reproduce it on my end 😞 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thumbnail-container. Selector must consider whole product miniature, not just the product cover where rating is loaded in Classic theme.Classic
Hummingbird